Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OAuth 2.0 With Private Key #23

Merged
merged 20 commits into from
Apr 17, 2024
Merged

Add OAuth 2.0 With Private Key #23

merged 20 commits into from
Apr 17, 2024

Conversation

mchavez
Copy link
Contributor

@mchavez mchavez commented Mar 29, 2024

  • Add OAuth 2.0 With Private Key

@mchavez mchavez marked this pull request as ready for review April 11, 2024 00:04
ggreer
ggreer reviewed Apr 11, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
cmd/baton-okta/config.go Outdated Show resolved Hide resolved
cmd/baton-okta/config.go Outdated Show resolved Hide resolved
pkg/connector/connector.go Outdated Show resolved Hide resolved
cmd/baton-okta/main.go Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
pkg/connector/connector.go Show resolved Hide resolved
ggreer
ggreer reviewed Apr 16, 2024
View reviewed changes
cmd/baton-okta/main.go Outdated Show resolved Hide resolved
pkg/connector/connector.go Outdated Show resolved Hide resolved
pkg/connector/connector.go Outdated Show resolved Hide resolved
ggreer
ggreer approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@ggreer ggreer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is better than what was there before and we discussed a better way to do the config stuff since the current type definition is in main. I say we merge this and then have a new PR for the config cleanup.

@ggreer ggreer merged commit 715c1b5 into main Apr 17, 2024
2 checks passed
@mgaeta mgaeta mentioned this pull request Aug 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggreer ggreer ggreer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mchavez @ggreer