Added Escalation Type #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loganintech
reviewed
Apr 23, 2024
| var rv []*v2.Entitlement | ||
|
|
||
| assignmentOptions := []ent.EntitlementOption{ | ||
| ent.WithGrantableTo(resourceTypeEscalation), |
There was a problem hiding this comment.
These are probably grantable to users (or teams) not escalations themselves. Self-referential grants seems weird for this
loganintech
reviewed
Apr 23, 2024
| assignmentOptions := []ent.EntitlementOption{ | ||
| ent.WithGrantableTo(resourceTypeEscalation), | ||
| ent.WithDisplayName(fmt.Sprintf("%s Escalation Member", resource.DisplayName)), | ||
| ent.WithDescription(fmt.Sprintf("Is member of the %s escalation in Opsgenie", resource.DisplayName)), |
There was a problem hiding this comment.
I'd probably word this different. You're not exactly a "member" of an escalation. Escalation policies apply to your team
|
Besides the git conflict, is there anything blocking this? It'd be nice to get it merged. |
So, looking more into Escalations they're basically rules to notify on-call people. They don't fit into resources/entitlements I think. Not sure how do we want to proceed. |
|
Hey @harikac1, are you still working on this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.