Don't require ticket status and type #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
laurenleach
commented
Jun 26, 2024
laurenleach
commented
- We don't require status but if the schema didn't include status we were still erroring
- Change ticket type to not be required since not all ticket systems require type
mgaeta
reviewed
Jun 26, 2024
pkg/types/ticket/custom_fields.go
Outdated
| @@ -265,10 +265,11 @@ func ValidateTicket(ctx context.Context, schema *v2.TicketSchema, ticket *v2.Tic | |||
| } | |||
|
|
|||
| // Look for a matching ticket type | |||
| foundMatch = false | |||
| foundMatch = ticket.Type == nil | |||
| for _, tType := range schema.GetTypes() { | |||
| if ticket.Type == nil { | |||
There was a problem hiding this comment.
The code block
if ticket.Type == nil {
foundMatch = true
break
}can be removed from the loop:
// Look for a matching status
// Status is not required
foundMatch := ticket.Status == nil
if !foundMatch {
for _, status := range schema.GetStatuses() {
if ticket.Status.GetId() == status.GetId() {
foundMatch = true
break
}
}
}
btipling
approved these changes
Jul 2, 2024
pkg/types/ticket/custom_fields.go
Outdated
| @@ -265,10 +265,11 @@ func ValidateTicket(ctx context.Context, schema *v2.TicketSchema, ticket *v2.Tic | |||
| } | |||
|
|
|||
| // Look for a matching ticket type | |||
| foundMatch = false | |||
| foundMatch = ticket.Type == nil | |||
There was a problem hiding this comment.
I might add a more specific comment here and above to explain why we do this, if a ticket doesn't have a status or a type we don't need to validate, skip the loop in this case
| @@ -265,10 +265,11 @@ func ValidateTicket(ctx context.Context, schema *v2.TicketSchema, ticket *v2.Tic | |||
| } | |||
|
|
|||
| // Look for a matching ticket type | |||
| foundMatch = false | |||
| @@ -245,7 +245,7 @@ func ValidateTicket(ctx context.Context, schema *v2.TicketSchema, ticket *v2.Tic | |||
| l := ctxzap.Extract(ctx) | |||
|
|
|||
| // Look for a matching status | |||
| foundMatch := false | |||
laurenleach
force-pushed
the
lauren/tickets-dont-require-status-and-type
branch
from
b277b15
to
706279c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.