Add generic thread-safe map implementation #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
raulb
added a commit
to ConduitIO/conduit
that referenced
this pull request
Sep 13, 2024
Uses ConduitIO/conduit-commons#116 Co-Authored-By: Lovro Mažgon <lovro.mazgon@gmail.com>
lovromazgon
added a commit
to ConduitIO/conduit
that referenced
this pull request
Sep 13, 2024
* wip * update method calls * use configuration * wip refactor * wip * move stream * add lifecycleService to runtime * fix * fix imports * no errors on lifecycle service * fix wait * update status through its method * it compiles * update interfaces * more test fixes * update mocks * add mocks and update tests * fix lint * remove GetInstances * delete key instead Co-Authored-By: Lovro Mažgon <lovro.mazgon@gmail.com> * ignore test files * delete test files * ensures runningPipeline is locked * fix not initialized map Co-Authored-By: Lovro Mažgon <lovro.mazgon@gmail.com> * fix tests * add back the needed test file * update comment * add comment * locks while retrieving the pipeline * update comment * unsure about the need for this * remove backoff from pipeline service * update method name on lifecycle service - changes run to init * lock running pipelines and optimize stopAll * remove redundant call to update status * fix typo * pr feedback * uses csync Map Uses ConduitIO/conduit-commons#116 Co-Authored-By: Lovro Mažgon <lovro.mazgon@gmail.com> * go mod tidy * update conduit-commons * go mod tidy --------- Co-authored-by: Lovro Mažgon <lovro.mazgon@gmail.com>
hariso
approved these changes
Sep 16, 2024
raulb
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Generic simple thread-safe map implementation.
Quick checks: