-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schemas: fix handling of nullable fields #132
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maha-hajja
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! thank you for the fix
lovromazgon
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Data unmarshaling is done in two phases: unmarshaling by Avro, which sometimes represents values with maps, and our own unmarshaling, where we substitute those maps with actual values. For example,
"my_field": map[string]any{"int": 1}
needs to be replaced with"my_fied": 1
.Value substitution needs to know what's the "parent" of a field, so that it can replace the value for it. Due to a bug, the value substitution for fields that are nullable (i.e. that have
null
in their union type) was triggered for all fields in the parent object. Because value substitution assumes that the values are in a special format (a map with just one key, where the key is the type, and the value is the actual value), we got an error, because the other fields aren't in that format.The actually fix is this part, where we check the type of the field. The rest of the changes are mostly comments and a bit of extracting code into methods.
Quick checks: