New snapshot iterator and position format #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The iterator supports snapshots based on range and is limited to tables which have an ordinal number (integer) as primary key. If these conditions are not met, validation will fail. Support for multiple tables is builtin. Each table gets a dedicated worker. Positional data keeps track of the progress of all tables, not just the one which the record is related to. Resuming a snapshot is supported, if the snapshot positional data requires it. This work is not integrated into the CDC or LongPoll iterator and the new position type is not compatible. This will work will follow.
7 tasks
lovromazgon
reviewed
Apr 17, 2024
hariso
reviewed
Apr 17, 2024
raulb
reviewed
Apr 17, 2024
hariso
reviewed
Apr 17, 2024
lovromazgon
reviewed
Apr 17, 2024
lovromazgon
reviewed
Apr 17, 2024
lovromazgon
reviewed
Apr 17, 2024
|
@lovromazgon addressed (I think) most of your comments here 2d60841 |
hariso
approved these changes
Apr 18, 2024
|
@hariso yeah I think we can postpone that, since these changes don't have any effect yet. |
raulb
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The iterator supports snapshots based on range and is limited to tables which have an ordinal number (integer) as primary key. If these conditions are not met, validation will fail.
Support for multiple tables is builtin. Each table gets a dedicated worker. Positional data keeps track of the progress of all tables, not just the one which the record is related to.
Resuming a snapshot is supported, if the snapshot positional data requires it.
This work is not integrated into the CDC or LongPoll iterator and the new position type is not compatible. This will work will follow.
Fixes # (issue)
Quick checks: