Add snapshot support to logrepl mode #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyuboxa
commented
May 6, 2024
lovromazgon
reviewed
May 7, 2024
hariso
reviewed
May 7, 2024
hariso
reviewed
May 7, 2024
lovromazgon
reviewed
May 8, 2024
lovromazgon
reviewed
May 8, 2024
lyuboxa
force-pushed
the
lk/cdc-snapshot-iterator
branch
from
a6c1322
to
0a0ba9a
Compare
lyuboxa
force-pushed
the
lk/cdc-snapshot-iterator
branch
from
0a0ba9a
to
22d4fb0
Compare
lyuboxa
changed the title
hariso
reviewed
May 10, 2024
The new combined iterator integrates snapshots with the existing cdc iterator. Once the snapshot is completed, it will swithc to cdc. When using snapshots, the connector will run both cdc and snapshot at the same time. This is required because the cdc iterator needs to be initialized and export a consistent snapshot which is taken at the time of the slot creation. The cdc iteator will need to keep the connection open until the snapshot is done. The switch to the cdc iterator is triggered when the snapshot returns an end of records error. Based on this signal, the cdc subscriber will be started to consume changes from the replication slot.
lyuboxa
force-pushed
the
lk/cdc-snapshot-iterator
branch
from
5d83fd8
to
10e4575
Compare
hariso
reviewed
May 14, 2024
hariso
reviewed
May 14, 2024
hariso
reviewed
May 14, 2024
hariso
approved these changes
May 14, 2024
lovromazgon
reviewed
May 14, 2024
Co-authored-by: Lovro Mažgon <lovro.mazgon@gmail.com>
Co-authored-by: Lovro Mažgon <lovro.mazgon@gmail.com>
lovromazgon
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The new combined iterator integrates snapshots with the existing cdc iterator.
Once the snapshot is completed, it will swithc to cdc.
When using snapshots, the connector will run both cdc and snapshot at the same time.
This is required because the cdc iterator needs to be initialized and export a consistent
snapshot which is taken at the time of the slot creation. The cdc iteator will need to
keep the connection open until the snapshot is done.
The switch to the cdc iterator is triggered when the snapshot returns an end of records error.
Based on this signal, the cdc subscriber will be started to consume changes from the replication slot.
Fixes #15
Quick checks: