Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve handling of keepalive messages and manage server end lag. #167

Merged
merged 8 commits into from
Jun 13, 2024
Merged

Improve handling of keepalive messages and manage server end lag. #167

merged 8 commits into from
Jun 13, 2024

Conversation

lyuboxa
Copy link
Contributor

@lyuboxa lyuboxa commented Jun 10, 2024 •
edited
Loading

Description

  • Ensure expected commit lsn matches that of begin messages.
  • Adjust the status update to send the last server lsn when all data nas been written and acked. This change will help with managing server lag with relatively less frequently updated tables.

Quick checks:

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@lyuboxa lyuboxa requested a review from a team as a code owner June 10, 2024 18:31
lovromazgon
lovromazgon reviewed Jun 11, 2024
View reviewed changes
source/logrepl/internal/subscription.go Outdated Show resolved Hide resolved
source/logrepl/internal/subscription.go Outdated Show resolved Hide resolved
@lyuboxa
Improve handling of keepalive messages and manage server end lag.
b23f18b 
* Ensure expected commit lsn matches that of begin messages.
* Adjust the status update to send the last server lsn
when all data nas been written and acked. This change will help with managing
server lag with relatively less frequently updated tables.
@lyuboxa
small change
42f788f
@lyuboxa
tests
4ef3cd5
@lyuboxa
refactor
54ef3e3
@lyuboxa
oops
65b36bd
@lyuboxa
tests
cab9343
@lyuboxa
adjust tests
b2b65dc
@lyuboxa
cr
351110f
@lyuboxa lyuboxa merged commit 9b84f73 into main Jun 13, 2024
3 checks passed
@lyuboxa lyuboxa deleted the lk/statusupdate-changes branch June 13, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovromazgon lovromazgon lovromazgon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lyuboxa @lovromazgon