Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix race in combined iterator test #183

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Fix race in combined iterator test #183

merged 1 commit into from
Jul 18, 2024

Conversation

lyuboxa
Copy link
Contributor

@lyuboxa lyuboxa commented Jul 18, 2024

Description

The fetchers may not have started right after the iterator is created. Interrupt after snapshotter has started.

Fixes Screenshot 2024-07-18 at 17 54 43

Quick checks:

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@lyuboxa
Fix race in combined iterator test
1b8c759 
The fetchers may not have started right after the iterator is created.
Interrupt after snapshotter has started.
@lyuboxa lyuboxa requested a review from a team as a code owner July 18, 2024 21:55
@lyuboxa lyuboxa merged commit 46654b2 into main Jul 18, 2024
3 checks passed
@lyuboxa lyuboxa deleted the lk/fix-race-in-test branch July 18, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maha-hajja maha-hajja maha-hajja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lyuboxa @maha-hajja