Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Recovery] Make backoff parameters globally configurable #1818

Merged
merged 5 commits into from
Sep 3, 2024
Merged

[Recovery] Make backoff parameters globally configurable #1818

merged 5 commits into from
Sep 3, 2024

Conversation

hariso
Copy link
Contributor

@hariso hariso commented Aug 30, 2024 •
edited
Loading

Description

Closes #1782.

I changed the parameter names slightly, since I believe it makes their purpose clearer:

  • pipeline.error-recovery.min -> min-delay (min itself doesn't explain minimum of what)
  • same for maximum delay
  • factor -> backoff-factor
  • retries -> max-retries

Quick checks

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@hariso hariso marked this pull request as ready for review August 30, 2024 16:50
@hariso hariso requested a review from a team as a code owner August 30, 2024 16:50
raulb
raulb reviewed Sep 3, 2024
View reviewed changes
Copy link
Member

@raulb raulb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hariso we only need to add a default value for healthy-after, and maybe add some tests on config_test. After that, this one is good to go.

pkg/conduit/config.go Show resolved Hide resolved
@hariso hariso enabled auto-merge (squash) September 3, 2024 12:21
@hariso hariso requested a review from raulb September 3, 2024 12:21
@hariso hariso merged commit 0e3280d into main Sep 3, 2024
3 checks passed
@hariso hariso deleted the haris/pipeline-recovery/config branch September 3, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulb raulb raulb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Recovery] Make backoff parameters globally configurable
2 participants
@hariso @raulb