Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't enrich id if it's not provided #1845

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Don't enrich id if it's not provided #1845

merged 2 commits into from
Sep 12, 2024

Conversation

lovromazgon
Copy link
Member

Description

Fixes a bug, where Conduit accepts a connector or processor without an ID in a pipeline config file.

Quick checks

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@lovromazgon lovromazgon requested a review from a team as a code owner September 11, 2024 15:53
@lovromazgon lovromazgon enabled auto-merge (squash) September 12, 2024 11:35
@lovromazgon lovromazgon merged commit af47e0f into main Sep 12, 2024
3 checks passed
@lovromazgon lovromazgon deleted the lovro/enrich-pipeline-config-fix branch September 12, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maha-hajja maha-hajja maha-hajja approved these changes

@raulb raulb raulb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lovromazgon @raulb @maha-hajja