Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: restart pipeline with recovery #1853

Merged
merged 49 commits into from
Oct 4, 2024
Merged

feat: restart pipeline with recovery #1853

merged 49 commits into from
Oct 4, 2024

Conversation

raulb
Copy link
Member

@raulb raulb commented Sep 16, 2024

Description

Fixes #1781 relying on its design document.

Quick checks

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@raulb raulb marked this pull request as ready for review September 20, 2024 13:25
@raulb raulb requested a review from a team as a code owner September 20, 2024 13:25
@raulb
Copy link
Member Author

raulb commented Sep 20, 2024

Created this separate issue to tackle what's remaining on this project #1862. Without that, we're setting the pipeline back to running as soon as we restarted the pipeline.

pkg/lifecycle/service.go Outdated Show resolved Hide resolved
pkg/lifecycle/service.go Outdated Show resolved Hide resolved
@raulb raulb requested a review from hariso October 3, 2024 18:32
Copy link
Contributor

@hariso hariso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@raulb raulb merged commit d7417fd into main Oct 4, 2024
4 checks passed
@raulb raulb deleted the raul/restart-with-recovery branch October 4, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Recovery] Recovery mechanism
3 participants