Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track recovery attempts using leaky bucket #1881

Merged
merged 7 commits into from
Oct 8, 2024
Merged

Track recovery attempts using leaky bucket #1881

merged 7 commits into from
Oct 8, 2024

Conversation

lovromazgon
Copy link
Member

@lovromazgon lovromazgon commented Oct 4, 2024 •
edited
Loading

Description

This PR implements tracking of recovery attempts using a leaky bucket. Once the bucket is full (i.e. we exceed the MaxRetries threshold) the pipeline is degraded instead of recovered.

Fixes #1862

Quick checks

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@lovromazgon lovromazgon mentioned this pull request Oct 4, 2024
Closed
4 tasks
@raulb raulb marked this pull request as ready for review October 8, 2024 16:34
@raulb raulb requested a review from a team as a code owner October 8, 2024 16:34
lovromazgon
lovromazgon commented Oct 8, 2024
View reviewed changes
Copy link
Member Author

@lovromazgon lovromazgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'd approve if I could, but I can't because I'm officially the author. Posted a nitpick, but that's about it 👍

pkg/lifecycle/service.go Outdated Show resolved Hide resolved
@raulb raulb merged commit 292193e into main Oct 8, 2024
4 checks passed
@raulb raulb deleted the lovro/recovery-healthy-after branch October 8, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulb raulb raulb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Recovery] Add delay after which fail count is reset
2 participants
@lovromazgon @raulb