Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load configs and directories from the working directory #1952

Merged
merged 3 commits into from
Nov 8, 2024

Conversation

hariso
Copy link
Contributor

@hariso hariso commented Nov 8, 2024

Description

Currently, Conduit looks for the configuration file location and the pipelines, connectors and processors directories in the same directory where the Conduit binary is running.

That's not always desirable, e.g. when Conduit is installed as a package. In that case, running conduit in a directory won't use the config file, pipelines, etc. from that directory, even though a user will likely expect that.

Hence, this PR changes Conduit's behavior to search for the config file and the directories in the working directory by default.

Quick checks

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

Copy link
Member

@raulb raulb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this a lot. Thank you @hariso

@raulb raulb merged commit 55ebed9 into main Nov 8, 2024
3 checks passed
@raulb raulb deleted the haris/load-configs-from-working-directory branch November 8, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants