Update Mox::Input Component UI and several light-mode UI tweaks #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c878739 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Test coverage: 92.49% 🤷♂️ Did not change |
jayjayjpg
force-pushed
the
jj/dark-light-mode-tweaks
branch
from
45cc5ca
to
e7a0262
Compare
|
Test coverage: 92.49% 🤷♂️ Did not change |
jayjayjpg
force-pushed
the
jj/dark-light-mode-tweaks
branch
3 times, most recently
from
b3d0b07
to
9b39fcc
Compare
jayjayjpg
changed the title
jayjayjpg
force-pushed
the
jj/dark-light-mode-tweaks
branch
from
9b39fcc
to
3a0ea6e
Compare
|
Test coverage: 92.49% 🤷♂️ Did not change |
1 similar comment
|
Test coverage: 92.49% 🤷♂️ Did not change |
jmar910
approved these changes
Jul 13, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/meroxa/platform-ui-v1/issues/1002
Part of https://github.com/meroxa/platform-ui-v1/issues/992
With this change, we're adding a new light mode variant to the
Mox::InputandMox::Labelcomponents. We're also tweaking the UI for theMox::LinkButtoncomponent to match the latest designs more accurately. Finally, we're updating any test scenarios for existing components that are reusingMox::Inputto specifically emulate the dark mode testing scenario when asserting for the component's style.Screens
Mox::Input
Mox::LinkButton