Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add links block to global header #120

Merged
merged 2 commits into from
Jul 17, 2023
Merged

Conversation

jmar910
Copy link
Member

@jmar910 jmar910 commented Jul 17, 2023

Shifts around our global header to support the new redesign

  • Remove help-menu since it is unused in platform dashboard (Using user-menu will suit our needs fine here)
  • Shifted env-switcher to right side of header
  • Added global-links block so we can add links in the header
Screen Shot 2023-07-17 at 11 27 43 AM

@jmar910 jmar910 self-assigned this Jul 17, 2023
@changeset-bot
Copy link

changeset-bot bot commented Jul 17, 2023

🦋 Changeset detected

Latest commit: 7d50ae0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
mx-ui-components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@jayjayjpg jayjayjpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads great, thank you for the quick update! ✨ What do you think about adding a changelog to this PR as well?

@jmar910 jmar910 force-pushed the james/redesign-global-header branch from 877f52f to 7850f11 Compare July 17, 2023 15:35
@jmar910 jmar910 force-pushed the james/redesign-global-header branch from 7850f11 to da74598 Compare July 17, 2023 17:12
@github-actions
Copy link
Contributor

Test coverage: 92.49%

🤷‍♂️ Did not change

@github-actions
Copy link
Contributor

Test coverage: 92.49%

🤷‍♂️ Did not change

@jmar910 jmar910 merged commit fef2136 into main Jul 17, 2023
4 checks passed
@jmar910 jmar910 deleted the james/redesign-global-header branch July 17, 2023 17:29
@meroxa-machine meroxa-machine mentioned this pull request Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants