Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: light mode mox:link + mox:tab-items #123

Merged
merged 1 commit into from
Jul 19, 2023
Merged

feat: light mode mox:link + mox:tab-items #123

merged 1 commit into from
Jul 19, 2023

Conversation

jmar910
Copy link
Member

@jmar910 jmar910 commented Jul 18, 2023 •
edited
Loading

Adds light mode tabs + light mode links with correct hover states

Screen Shot 2023-07-18 at 2 44 10 PM

@jmar910 jmar910 self-assigned this Jul 18, 2023
@changeset-bot
Copy link

changeset-bot bot commented Jul 18, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: ae815ba

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jmar910 jmar910 requested a review from jayjayjpg July 18, 2023 18:53
jayjayjpg
jayjayjpg approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@jayjayjpg jayjayjpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing these changes so quickly, this reads great and looks nice on the Storybook deployment as well! ✨

Light

light-tabs

Dark

dark-tabs

stories/mox-link-light.stories.js Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice story! ✨

jayjayjpg
jayjayjpg approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@jayjayjpg jayjayjpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the super quick turnaround on these, this reads great! ✨

tests/integration/components/mox/tabs/item-test.js
});

test('it is rendered as arg-active when the `@isActive` argument is set', async function (assert) {
test('it is rendered as inactive by default (light mode)', async function (assert) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those additional test cases read great!

@github-actions
Copy link
Contributor

Test coverage: 92.49%

🤷‍♂️ Did not change

@jmar910 jmar910 merged commit ea30bde into main Jul 19, 2023
@jmar910 jmar910 deleted the james/light-mode-tabs branch July 19, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayjayjpg jayjayjpg jayjayjpg approved these changes

Assignees

@jmar910 jmar910

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmar910 @jayjayjpg