Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upd(mox:upload): add light mode for mox:upload comp. #131

Merged
merged 2 commits into from
Jul 24, 2023

Conversation

jayjayjpg
Copy link
Contributor

@jayjayjpg jayjayjpg commented Jul 24, 2023

Part of https://github.com/meroxa/platform-ui-v1/issues/1029

With this change, we're adding a light-mode variant to the following components:

  • Mox::Upload

Blockers

Screens

Mox::Upload

dark mode light mode
upload-dark upload-light

@changeset-bot
Copy link

changeset-bot bot commented Jul 24, 2023

🦋 Changeset detected

Latest commit: 8b7043e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
mx-ui-components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jayjayjpg jayjayjpg force-pushed the jj/light-mode-form-fields-2 branch from dd730d0 to 66b57be Compare July 24, 2023 11:45
@github-actions
Copy link
Contributor

Test coverage: 92.51%

🎉 Increased by +0.02% (was 92.49%)

1 similar comment
@github-actions
Copy link
Contributor

Test coverage: 92.51%

🎉 Increased by +0.02% (was 92.49%)

@jmar910
Copy link
Member

jmar910 commented Jul 24, 2023

Whoops lol did not mean to approve this 😅

@jayjayjpg jayjayjpg force-pushed the jj/light-mode-form-fields-2 branch from 66b57be to 2a39fa9 Compare July 24, 2023 17:23
@github-actions
Copy link
Contributor

Test coverage: 92.51%

🎉 Increased by +0.02% (was 92.49%)

@jayjayjpg jayjayjpg marked this pull request as ready for review July 24, 2023 17:50
@jmar910
Copy link
Member

jmar910 commented Jul 24, 2023

Haha okay for real this is approved now 👍 🚀

@github-actions
Copy link
Contributor

Test coverage: 92.51%

🎉 Increased by +0.02% (was 92.49%)

@jayjayjpg jayjayjpg merged commit 36874ed into main Jul 24, 2023
4 checks passed
@jayjayjpg jayjayjpg deleted the jj/light-mode-form-fields-2 branch July 24, 2023 18:01
@meroxa-machine meroxa-machine mentioned this pull request Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants