Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mox:select): add light mode to mox/select components #134

Merged
merged 4 commits into from
Jul 25, 2023

Conversation

jayjayjpg
Copy link
Contributor

@jayjayjpg jayjayjpg commented Jul 25, 2023

Closes https://github.com/meroxa/platform-ui-v1/issues/1029

With this PR, we're adding a light mode variant for the following components:

  • Mox::Select
  • Mox::SelectOption
  • Mxa::SelectOption::Category (used within Mox::SelectOption and Mxa::SelectOption)
  • Mox::TypeaheadSelect

Screens

Mox::Select

dark mode light mode
select-dark select-light

Mox::TypeaheadSelect

dark mode light mode
typea-dark typea-light

@changeset-bot
Copy link

changeset-bot bot commented Jul 25, 2023

🦋 Changeset detected

Latest commit: 6ff01f5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
mx-ui-components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

Test coverage: 92.69%

🎉 Increased by +0.18% (was 92.51%)

@jayjayjpg jayjayjpg force-pushed the jj/light-mode-form-fields-4 branch from c6c16fc to 2047570 Compare July 25, 2023 11:33
@github-actions
Copy link
Contributor

Test coverage: 92.69%

🎉 Increased by +0.18% (was 92.51%)

@jayjayjpg jayjayjpg force-pushed the jj/light-mode-form-fields-4 branch from 8078495 to ce14d30 Compare July 25, 2023 12:00
@github-actions
Copy link
Contributor

Test coverage: 92.69%

🎉 Increased by +0.18% (was 92.51%)

@github-actions
Copy link
Contributor

Test coverage: 92.69%

🚨 No before coverage could be loaded

@jayjayjpg jayjayjpg force-pushed the jj/light-mode-form-fields-4 branch from ce14d30 to cb35c69 Compare July 25, 2023 12:53
@jayjayjpg jayjayjpg marked this pull request as ready for review July 25, 2023 12:54
@jayjayjpg jayjayjpg force-pushed the jj/light-mode-form-fields-4 branch from f7f43a3 to da893be Compare July 25, 2023 13:05
@jayjayjpg jayjayjpg force-pushed the jj/light-mode-form-fields-4 branch from 912a668 to 6ff01f5 Compare July 25, 2023 13:42
@github-actions
Copy link
Contributor

Test coverage: 92.69%

🎉 Increased by +0.18% (was 92.51%)

Copy link
Member

@jmar910 jmar910 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@jayjayjpg jayjayjpg merged commit d259dfa into main Jul 25, 2023
4 checks passed
@jayjayjpg jayjayjpg deleted the jj/light-mode-form-fields-4 branch July 25, 2023 16:02
@meroxa-machine meroxa-machine mentioned this pull request Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants