-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mox:select): add light mode to mox/select components #134
Conversation
🦋 Changeset detectedLatest commit: 6ff01f5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Test coverage: 92.69% 🎉 Increased by +0.18% (was 92.51%) |
c6c16fc
to
2047570
Compare
Test coverage: 92.69% 🎉 Increased by +0.18% (was 92.51%) |
8078495
to
ce14d30
Compare
Test coverage: 92.69% 🎉 Increased by +0.18% (was 92.51%) |
Test coverage: 92.69% 🚨 No before coverage could be loaded |
ce14d30
to
cb35c69
Compare
f7f43a3
to
da893be
Compare
e8d819c
to
912a668
Compare
912a668
to
6ff01f5
Compare
Test coverage: 92.69% 🎉 Increased by +0.18% (was 92.51%) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Closes https://github.com/meroxa/platform-ui-v1/issues/1029
With this PR, we're adding a light mode variant for the following components:
Mox::Select
Mox::SelectOption
Mxa::SelectOption::Category
(used withinMox::SelectOption
andMxa::SelectOption
)Mox::TypeaheadSelect
Screens
Mox::Select
Mox::TypeaheadSelect