deps(ember): upgrade app to ember@4.12 + export of ember-modifier as direct dependency #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 812e151 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Test coverage: 92.29% 🚨 No before coverage could be loaded |
jayjayjpg
force-pushed
the
jj/ember-upgrade-4.8
branch
from
e2a270a
to
812e151
Compare
|
Test coverage: 92.29% 🚨 No before coverage could be loaded |
1 similar comment
|
Test coverage: 92.29% 🚨 No before coverage could be loaded |
jmar910
reviewed
Apr 26, 2023
| "ember-keyboard": "8.2.0", | ||
| "ember-modifier": "^4.1.0", |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/meroxa/platform-ui-v1/issues/881
Part of https://github.com/meroxa/product/issues/749
Closes #51
With this change, we're
ember@4.12ember-modifieras a direct dependency as required for the upgrade of our host applicationOnce this is merged and released, the upgrade work in https://github.com/meroxa/platform-ui-v1/issues/881 will be unblocked.
Demo
Chromatic Build: https://www.chromatic.com/build?appId=6109b9596e1c1300390c39c5&number=241