Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps(engine): upgrade engine.io to latest sec. patched version #61

Merged
merged 2 commits into from
May 11, 2023

Conversation

jayjayjpg
Copy link
Contributor

Closes https://github.com/ConduitIO/mx-ui-components/security/dependabot/88

Impact
A specially crafted HTTP request can trigger an uncaught exception on the Engine.IO server, thus killing the Node.js process.

TypeError: Cannot read properties of undefined (reading 'handlesUpgrades') at Server.onWebSocket (build/server.js:515:67) This impacts all the users of the [engine.io](https://www.npmjs.com/package/engine.io) package, including those who uses depending packages like [socket.io](https://www.npmjs.com/package/socket.io).

Patches
A fix has been released today (2023/05/02): 6.4.2

This bug was introduced in version 5.1.0 and included in version 4.1.0 of the socket.io parent package. Older versions are not impacted.

@changeset-bot
Copy link

changeset-bot bot commented May 8, 2023

⚠️ No Changeset found

Latest commit: 64c537c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jayjayjpg jayjayjpg requested a review from simonl2002 May 11, 2023 17:59
Copy link
Member

@simonl2002 simonl2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions
Copy link
Contributor

Test coverage: 92.29%

🤷‍♂️ Did not change

@jayjayjpg jayjayjpg merged commit c8e9028 into main May 11, 2023
@jayjayjpg jayjayjpg deleted the jj/engine-upgrade branch May 11, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants