Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps(socket): upgrade socket.io-parser to latest security patch version #90

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

jayjayjpg
Copy link
Contributor

Closes https://github.com/ConduitIO/mx-ui-components/security/dependabot/90

With this change, we're pinning the resolved version for socket.io-parser to include the latest security patch for the following vulnerability:

Impact
A specially crafted Socket.IO packet can trigger an uncaught exception on the Socket.IO server, thus killing the Node.js process.

TypeError: Cannot convert object to primitive value
at Socket.emit (node:events:507:25)
at .../node_modules/socket.io/lib/socket.js:531:14

@changeset-bot
Copy link

changeset-bot bot commented Jun 13, 2023

⚠️ No Changeset found

Latest commit: 262a1f8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

Test coverage: 92.35%

🤷‍♂️ Did not change

Copy link

@janelletavares janelletavares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jayjayjpg jayjayjpg merged commit 8036b84 into main Jun 13, 2023
@jayjayjpg jayjayjpg deleted the jj/sockets branch June 13, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants