Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs #474 -- Add "Ways Lenders Lose Out in DeFi Lending Protocols" to Contract Security #664

Conversation

jackleeio
Copy link
Contributor

@jackleeio jackleeio commented Jul 14, 2024

Pre-flight checklist


This change is Reviewable

Copy link

vercel bot commented Jul 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
conflux-documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 14, 2024 11:18am

Copy link
Collaborator

@darwintree darwintree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the content is generally correct but I would want to know the target audience of this article and the purpose of the article.
For current version, it seems that this article is written as if it were for lending protocol designers and developers. However, lending protocols are quite delicate and complex to design and implement. And I don't think our site is that important enough for them to refer to.
I think the content is good enough, but I would know your original idea of the target audience of this article so it can be made clear who need to read it

@jackleeio
Copy link
Contributor Author

I consider the development of lending protocols to be a part of smart contract development. This article provides a summary of common issues, with some preventive measures mentioned in previous articles. For beginners or intermediate developers who may encounter lending protocol development, this article can be helpful.

@darwintree
Copy link
Collaborator

darwintree commented Jul 16, 2024

I consider the development of lending protocols to be a part of smart contract development. This article provides a summary of common issues, with some preventive measures mentioned in previous articles. For beginners or intermediate developers who may encounter lending protocol development, this article can be helpful.

I agree that these common issues are useful. However, similar to Why is it wrong to implement myself a known, published, widely believed to be secure crypto algorithm?, I think it never a good practice for beginners as well as intermediate developers to directly engage at least in the development of lending protocol itself. And that is why I mainly focus on the target audience

@jackleeio
Copy link
Contributor Author

I think it never a good practice for beginners as well as intermediate developers to directly engage at least in the development of lending protocol itself. And that is why I mainly focus on the target audience

I think you misunderstood my point. The aim is not to encourage beginners or intermediate devs to directly engage in the development of lending protocols. Rather, it is to provide necessary information to devs who need it, such as those interested in understanding the security aspects of lending protocol contracts, or those wanting to develop DeFi projects on Conflux.

This content can serve as a reference or guide to help them develop more secure DeFi applications on Conflux.

@jackleeio
Copy link
Contributor Author

If you feel that this content is not suitable for the current context, I would want to know if it would be possible to start a new series focusing on common vulnerabilities and prevention methods related to lending or staking protocols (though some content might overlap with the current contract security series). Alternatively, I could break down the current article into several detailed parts and incorporate them into the current contract security series.

@darwintree
Copy link
Collaborator

If you feel that this content is not suitable for the current context, I would want to know if it would be possible to start a new series focusing on common vulnerabilities and prevention methods related to lending or staking protocols (though some content might overlap with the current contract security series). Alternatively, I could break down the current article into several detailed parts and incorporate them into the current contract security series.

Yes, I think that is a good point and we can also give some basic introduction to these well known protocols. Besides, we can also create a folder in the general folder containing general advices or suggestions relating to blockchain security mainly for users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants