-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RPC methods for CIP 1559 #191
Conversation
eSpace debug RPC methods are not supported due to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @wanliqun)
rpc/cfx_api.go
line 474 at r1 (raw file):
) (feeHistory *types.FeeHistory, err error) { cfx := GetCfxClientFromContext(ctx) return cfx.GetFeeHistory(blockCount, lastEpoch, rewardPercentiles)
Any limitations for the length of rewardPercentiles
?
Previously, boqiu (Bo QIU) wrote…
This argument is optional, which means we can pass an empty array. Also there is no max limit per to existing Ethereum RPC specification. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @wanliqun)
Previously, wanliqun (Liqun) wrote…
Enforce a hard limit for |
This change is