Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RPC methods for CIP 1559 #191

Merged
merged 3 commits into from
Jun 11, 2024
Merged

Add RPC methods for CIP 1559 #191

merged 3 commits into from
Jun 11, 2024

Conversation

wanliqun
Copy link
Contributor

@wanliqun wanliqun commented Jun 11, 2024

This change is Reviewable

@wanliqun wanliqun requested a review from boqiu June 11, 2024 08:45
@wanliqun
Copy link
Contributor Author

eSpace debug RPC methods are not supported due to web3go sdk is not ready yet.

Copy link
Contributor

@boqiu boqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @wanliqun)


rpc/cfx_api.go line 474 at r1 (raw file):

) (feeHistory *types.FeeHistory, err error) {
	cfx := GetCfxClientFromContext(ctx)
	return cfx.GetFeeHistory(blockCount, lastEpoch, rewardPercentiles)

Any limitations for the length of rewardPercentiles?

@wanliqun
Copy link
Contributor Author

rpc/cfx_api.go line 474 at r1 (raw file):

Previously, boqiu (Bo QIU) wrote…

Any limitations for the length of rewardPercentiles?

This argument is optional, which means we can pass an empty array. Also there is no max limit per to existing Ethereum RPC specification.

Copy link
Contributor

@boqiu boqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @wanliqun)

@wanliqun
Copy link
Contributor Author

rpc/cfx_api.go line 474 at r1 (raw file):

Previously, wanliqun (Liqun) wrote…

This argument is optional, which means we can pass an empty array. Also there is no max limit per to existing Ethereum RPC specification.

Enforce a hard limit for rewardPercentitles length to be 50.

@wanliqun wanliqun merged commit 5a9d7fe into main Jun 11, 2024
2 checks passed
@wanliqun wanliqun deleted the support-cip-1559 branch June 11, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants