Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix bugs #1036

Merged
merged 3 commits into from
May 19, 2022
Merged

fix: fix bugs #1036

merged 3 commits into from
May 19, 2022

Conversation

RickStormBringer
Copy link
Contributor

@RickStormBringer RickStormBringer commented May 18, 2022

1.PORTAL-3102
2.PORTAL-3103
3.PORTAL-3101


This change is Reviewable

@AngeliaQ
Copy link
Contributor

Task linked: PORTAL-3103 DApp Favicon 的问题

@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #1036 (5cc1878) into dev (46907d1) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head 5cc1878 differs from pull request most recent head c9a9361. Consider uploading reports for the commit c9a9361 to get more accurate results

@@            Coverage Diff             @@
##              dev    #1036      +/-   ##
==========================================
- Coverage   39.82%   39.80%   -0.02%     
==========================================
  Files         567      567              
  Lines       33881    33898      +17     
  Branches     1923     1923              
==========================================
  Hits        13493    13493              
- Misses      20204    20221      +17     
  Partials      184      184              
Flag Coverage Δ
integrationtests 31.64% <0.00%> (-0.02%) ⬇️
unittests 27.06% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/popup/src/components/Avatar.js 0.00% <0.00%> (ø)
...ackages/popup/src/components/DappProgressHeader.js 0.00% <0.00%> (ø)
packages/popup/src/components/TokenItem.js 0.00% <0.00%> (ø)
packages/popup/src/hooks/index.js 0.00% <0.00%> (ø)
packages/popup/src/hooks/useApi.js 0.00% <0.00%> (ø)
...src/pages/AuthorizedWebsite/components/DappItem.js 0.00% <0.00%> (ø)
...rc/pages/ConfirmTransaction/components/InfoList.js 0.00% <0.00%> (ø)
.../popup/src/pages/History/components/HistoryItem.js 0.00% <0.00%> (ø)
...ckages/popup/src/pages/Home/components/AddToken.js 0.00% <0.00%> (ø)
...ges/popup/src/pages/Home/components/CurrentDapp.js 0.00% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46907d1...c9a9361. Read the comment docs.

@RickStormBringer RickStormBringer changed the title feat: add PORTAL-3103 fix: fix bugs May 18, 2022
@RickStormBringer RickStormBringer marked this pull request as draft May 18, 2022 23:48
@RickStormBringer RickStormBringer marked this pull request as ready for review May 19, 2022 02:35
@RickStormBringer RickStormBringer requested a review from AngeliaQ May 19, 2022 06:21
@RickStormBringer RickStormBringer force-pushed the fix-logic-bugs branch 3 times, most recently from 5cc1878 to 2823f3a Compare May 19, 2022 10:29
@mergify mergify bot merged commit 2789cef into dev May 19, 2022
@mergify mergify bot deleted the fix-logic-bugs branch May 19, 2022 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants