Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: PORTAL-3110 #1061

Merged
merged 2 commits into from
May 23, 2022
Merged

fix: PORTAL-3110 #1061

merged 2 commits into from
May 23, 2022

Conversation

AngeliaQ
Copy link
Contributor

@AngeliaQ AngeliaQ commented May 23, 2022

This change is Reviewable

@AngeliaQ
Copy link
Contributor Author

@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #1061 (c29b26c) into dev (31155cf) will decrease coverage by 12.75%.
The diff coverage is 0.00%.

❗ Current head c29b26c differs from pull request most recent head f9ac8f8. Consider uploading reports for the commit f9ac8f8 to get more accurate results

@@             Coverage Diff             @@
##              dev    #1061       +/-   ##
===========================================
- Coverage   39.81%   27.05%   -12.76%     
===========================================
  Files         567      567               
  Lines       33926    33925        -1     
  Branches     1924     1257      -667     
===========================================
- Hits        13508     9180     -4328     
- Misses      20234    24565     +4331     
+ Partials      184      180        -4     
Flag Coverage Δ
integrationtests ?
unittests 27.05% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/popup/src/hooks/index.js 0.00% <0.00%> (ø)
packages/inner-utils/env.js 0.00% <0.00%> (-100.00%) ⬇️
packages/inner-utils/index.js 0.00% <0.00%> (-100.00%) ⬇️
packages/background/src/db-schema.js 0.00% <0.00%> (-100.00%) ⬇️
packages/sentry/computeDefaultOptions.js 0.00% <0.00%> (-100.00%) ⬇️
packages/background/src/rpc-engine-opts.js 0.00% <0.00%> (-100.00%) ⬇️
packages/background/src/init-db.js 0.00% <0.00%> (-98.88%) ⬇️
packages/typed-data-spec/index.js 3.70% <0.00%> (-96.30%) ⬇️
packages/rpc-engine/index.js 16.80% <0.00%> (-83.20%) ⬇️
packages/background/src/index.js 0.00% <0.00%> (-75.43%) ⬇️
... and 88 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31155cf...f9ac8f8. Read the comment docs.

@mergify mergify bot merged commit 7e375ba into dev May 23, 2022
@mergify mergify bot deleted the fix-bugs-wyq branch May 23, 2022 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants