Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change network url #1324

Merged
merged 8 commits into from
Nov 9, 2022
Merged

feat: change network url #1324

merged 8 commits into from
Nov 9, 2022

Conversation

zctocm
Copy link
Contributor

@zctocm zctocm commented Nov 8, 2022

This change is Reviewable

@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Merging #1324 (087dd35) into dev (5ea73d5) will increase coverage by 0.03%.
The diff coverage is 56.49%.

@@            Coverage Diff             @@
##              dev    #1324      +/-   ##
==========================================
+ Coverage   35.73%   35.77%   +0.03%     
==========================================
  Files         606      606              
  Lines       38855    38935      +80     
  Branches     2015     2014       -1     
==========================================
+ Hits        13886    13929      +43     
- Misses      24756    24793      +37     
  Partials      213      213              
Flag Coverage Δ
integrationtests 28.63% <56.49%> (+0.05%) ⬆️
unittests 24.28% <0.64%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/popup/src/constants/index.js 0.00% <0.00%> (ø)
packages/rpcs/wallet_afterUnlock/index.js 65.51% <0.00%> (-5.13%) ⬇️
packages/rpcs/wallet_getNetwork/index.js 44.57% <0.00%> (-17.09%) ⬇️
packages/rpcs/cfx_gasPrice/index.js 46.15% <50.00%> (ø)
packages/background/src/index.js 81.76% <100.00%> (+6.33%) ⬆️
packages/background/src/init-db.js 98.98% <100.00%> (+0.10%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@RickStormBringer RickStormBringer merged commit 1053887 into dev Nov 9, 2022
@RickStormBringer RickStormBringer deleted the feature/change-network-url branch November 9, 2022 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants