Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix ui bugs #1344

Merged
merged 2 commits into from
Dec 12, 2022
Merged

fix: fix ui bugs #1344

merged 2 commits into from
Dec 12, 2022

Conversation

RickStormBringer
Copy link
Contributor

@RickStormBringer RickStormBringer commented Dec 8, 2022

1.PORTAL-3495
2.PORTAL-3494


This change is Reviewable

@AngeliaQ
Copy link
Contributor

AngeliaQ commented Dec 8, 2022

@AngeliaQ
Copy link
Contributor

AngeliaQ commented Dec 8, 2022

@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Merging #1344 (5605e2d) into dev (4fccc8d) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              dev    #1344      +/-   ##
==========================================
- Coverage   34.90%   34.90%   -0.01%     
==========================================
  Files         615      615              
  Lines       39943    39946       +3     
  Branches     1917     1917              
==========================================
  Hits        13942    13942              
- Misses      25791    25794       +3     
  Partials      210      210              
Flag Coverage Δ
integrationtests 27.97% <0.00%> (-0.01%) ⬇️
unittests 23.69% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/popup/src/components/NsNameLabel.js 0.00% <0.00%> (ø)
...p/src/pages/History/components/TransitionDetail.js 0.00% <0.00%> (ø)
...ansaction/components/AddressWithAlternativeName.js 0.00% <0.00%> (ø)
...pages/SendTransaction/components/ToAddressInput.js 0.00% <0.00%> (ø)
packages/popup/src/pages/SendTransaction/index.js 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@RickStormBringer RickStormBringer marked this pull request as draft December 9, 2022 02:16
@RickStormBringer RickStormBringer marked this pull request as ready for review December 9, 2022 03:25
@mergify mergify bot merged commit 7b304e2 into dev Dec 12, 2022
@mergify mergify bot deleted the fix/logic-bugs branch December 12, 2022 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants