Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix get version bug #1447

Merged
merged 3 commits into from
Nov 29, 2024
Merged

fix get version bug #1447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
06e3327
chore: fix get package version bug (#1441)
iosh Nov 26, 2024
e62b7cb
chore: fix get package version bug
iosh Nov 29, 2024
47c23a3
chore: version check
iosh Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .yarn/versions/c4d6a83d.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
declined:
- helios
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "helios",
"private": true,
"version": "2.7.6",
"version": "2.7.7",
"workspaces": [
"websites/*",
"packages/doc-ui/*",
Expand Down
30 changes: 14 additions & 16 deletions scripts/webpack.config.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,8 @@ const path = require('node:path')
const MiniCssExtractPlugin = require('mini-css-extract-plugin')
const HtmlWebpackPlugin = require('html-webpack-plugin')
const CopyPlugin = require('copy-webpack-plugin')
const {ProvidePlugin} = require('webpack')
const {ProvidePlugin, DefinePlugin} = require('webpack')
const {ProgressPlugin} = require('webpack')
const {EsbuildPlugin} = require('esbuild-loader')
const packageJson = require('../package.json')
const packagesPath = path.join(path.resolve(), './packages')
const devMode = process.env.NODE_ENV !== 'production'
Expand Down Expand Up @@ -110,11 +109,14 @@ const defaultConfig = {
https: false,
buffer: require.resolve('buffer/'),
stream: require.resolve('stream-browserify'),
process: 'process/browser',
process: 'process/browser',
},
alias: {
'/images': path.join(packagesPath, 'browser-extension/images'),
"js-conflux-sdk": path.join(path.resolve(), './node_modules/js-conflux-sdk'),
'js-conflux-sdk': path.join(
path.resolve(),
'./node_modules/js-conflux-sdk',
),
},
},
plugins: [
Expand All @@ -123,18 +125,14 @@ const defaultConfig = {
React: 'react',
process: 'process/browser.js',
}),
new EsbuildPlugin({
define: {
'process.env.NODE_DEBUG': JSON.stringify(
process.env.NODE_DEBUG || false,
),
'process.env.NODE_ENV': JSON.stringify(process.env.NODE_ENV),
'process.env.CI': JSON.stringify(process.env.CI || false),
'process.env.SENTRY_DSN': JSON.stringify(
process.env.SNOWPACK_PUBLIC_SENTRY_DSN || '',
),
'process.env.PACKAGE_VERSION': JSON.stringify(packageJson.version),
},
new DefinePlugin({
'process.env.NODE_DEBUG': JSON.stringify(process.env.NODE_DEBUG || false),
'process.env.NODE_ENV': JSON.stringify(process.env.NODE_ENV),
'process.env.CI': JSON.stringify(process.env.CI || false),
'process.env.SENTRY_DSN': JSON.stringify(
process.env.SNOWPACK_PUBLIC_SENTRY_DSN || '',
),
'process.env.PACKAGE_VERSION': JSON.stringify(packageJson.version),
}),
// Plugin to not generate js bundle for manifest entry
new HtmlWebpackPlugin({
Expand Down
Loading