Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix firefox build not match #1506

Merged
merged 2 commits into from
Jan 8, 2025
Merged

fix firefox build not match #1506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e25ffa5
chore: fix firefox build not match
iosh Jan 8, 2025
0b5e7df
chore: bump version
iosh Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .yarn/versions/01a87f4a.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,4 +164,5 @@ declined:
- "@fluent-wallet/wallet_validate-private-key"
- "@fluent-wallet/wallet_watch-asset"
- "@fluent-wallet/wallet_zero-account-group"
- "@fluent-wallet/inner-utils"
- workspace-tools
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "helios",
"private": true,
"version": "2.7.9",
"version": "2.7.10",
"workspaces": [
"websites/*",
"packages/doc-ui/*",
Expand Down
2 changes: 0 additions & 2 deletions packages/background/src/rpc-engine-opts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,6 @@ import * as ethMaxPriorityFeePerGas from '@fluent-wallet/eth_max-priority-fee-pe
import * as ethEstimate1559Fee from '@fluent-wallet/eth_estimate-1559-fee'

import {
IS_CI,
IS_DEV_MODE,
IS_PROD_MODE,
IS_TEST_MODE,
Expand Down Expand Up @@ -182,7 +181,6 @@ export const rpcEngineOpts = {
isProd: IS_PROD_MODE,
isDev: IS_DEV_MODE,
isTest: IS_TEST_MODE,
isCI: IS_CI,
methods: [
walletMetadataForPopup,
walletDbQuery,
Expand Down
1 change: 0 additions & 1 deletion packages/inner-utils/env.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,5 @@ export const MODE = import.meta.env
export const IS_TEST_MODE = MODE === 'test'
export const IS_DEV_MODE = MODE === 'development'
export const IS_PROD_MODE = MODE === 'production'
export const IS_CI = process.env.CI === 'true'

export const PACKAGE_VERSION = process.env.PACKAGE_VERSION
4 changes: 2 additions & 2 deletions packages/rpc-engine/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ const request = (s, req = {}) => {
}

const defRpcEngineFactory = (db, options = {methods: []}) => {
const {methods, isProd = true, isDev, isTest, isCI} = options
const {methods, isProd = true, isDev, isTest} = options
const rpcStore = new Object() // to store rpc defination

methods.forEach(rpc => {
Expand Down Expand Up @@ -92,7 +92,7 @@ const defRpcEngineFactory = (db, options = {methods: []}) => {
const processSpec = ({ins, fn, outs}) => ({
ins: {
...ins,
MODE: {const: {isProd, isDev, isTest, isCI}},
MODE: {const: {isProd, isDev, isTest}},
db: {const: db},
rpcStore: {const: rpcStore},
sendNewRpcRequest: {const: () => sendNewRpcRequest},
Expand Down
Loading