Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: more robust integration test #678

Merged
merged 1 commit into from
Jan 27, 2022
Merged

test: more robust integration test #678

merged 1 commit into from
Jan 27, 2022

Conversation

yqrashawn
Copy link
Contributor

@yqrashawn yqrashawn commented Jan 26, 2022

This change is Reviewable

@yqrashawn yqrashawn force-pushed the test/integration-test branch from 12883e6 to a6ba938 Compare January 26, 2022 12:42
@codecov
Copy link

codecov bot commented Jan 26, 2022

Codecov Report

Merging #678 (a6ba938) into dev (9fe0f3c) will increase coverage by 13.48%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##              dev     #678       +/-   ##
===========================================
+ Coverage   29.86%   43.34%   +13.48%     
===========================================
  Files         517      517               
  Lines       27861    27861               
  Branches     1196     1871      +675     
===========================================
+ Hits         8321    12077     +3756     
+ Misses      19372    15611     -3761     
- Partials      168      173        +5     
Flag Coverage Δ
integrationtests 32.40% <ø> (?)
unittests 29.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/rpc-engine/src/error.js 79.66% <0.00%> (+3.38%) ⬆️
...ackages/rpcs/cfx_estimateGasAndCollateral/index.js 100.00% <0.00%> (+3.63%) ⬆️
packages/rpcs/wallet_getAccountGroup/index.js 94.28% <0.00%> (+4.28%) ⬆️
packages/webextension/popup.js 24.81% <0.00%> (+5.83%) ⬆️
packages/signature/index.js 72.56% <0.00%> (+6.70%) ⬆️
packages/rpc-engine/src/permissions.js 100.00% <0.00%> (+8.33%) ⬆️
packages/rpcs/eth_estimateGas/index.js 100.00% <0.00%> (+8.33%) ⬆️
packages/rpcs/cfx_call/index.js 100.00% <0.00%> (+8.51%) ⬆️
packages/rpcs/eth_chainId/index.js 100.00% <0.00%> (+9.09%) ⬆️
packages/rpcs/net_version/index.js 100.00% <0.00%> (+9.09%) ⬆️
... and 81 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fe0f3c...a6ba938. Read the comment docs.

@mergify mergify bot merged commit 29a83cc into dev Jan 27, 2022
@mergify mergify bot deleted the test/integration-test branch January 27, 2022 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants