Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix bugs #800

Merged
merged 2 commits into from
Mar 8, 2022
Merged

fix: fix bugs #800

merged 2 commits into from
Mar 8, 2022

Conversation

RickStormBringer
Copy link
Contributor

@RickStormBringer RickStormBringer commented Mar 8, 2022

PORTAL-2745


This change is Reviewable

@AngeliaQ
Copy link
Contributor

AngeliaQ commented Mar 8, 2022

@codecov
Copy link

codecov bot commented Mar 8, 2022

Codecov Report

Merging #800 (6184f2d) into dev (4c00b6c) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #800      +/-   ##
==========================================
- Coverage   42.13%   42.12%   -0.02%     
==========================================
  Files         557      557              
  Lines       30875    30885      +10     
  Branches     1869     1869              
==========================================
  Hits        13010    13010              
- Misses      17683    17693      +10     
  Partials      182      182              
Flag Coverage Δ
integrationtests 32.77% <0.00%> (-0.02%) ⬇️
unittests 29.25% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/popup/src/pages/ConnectSite/index.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c00b6c...6184f2d. Read the comment docs.

@mergify mergify bot merged commit 75f7a85 into dev Mar 8, 2022
@mergify mergify bot deleted the fix-logic-bugs branch March 8, 2022 06:58
AngeliaQ pushed a commit that referenced this pull request Mar 16, 2022
* fix: fix PORTAL-2716

* fix: fix PORTAL-2745
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants