Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix PORTAL-2820 #843

Merged
merged 1 commit into from
Mar 29, 2022
Merged

fix: fix PORTAL-2820 #843

merged 1 commit into from
Mar 29, 2022

Conversation

RickStormBringer
Copy link
Contributor

@RickStormBringer RickStormBringer commented Mar 29, 2022

PORTAL-2820


This change is Reviewable

@AngeliaQ
Copy link
Contributor

@codecov
Copy link

codecov bot commented Mar 29, 2022

Codecov Report

Merging #843 (e8a7eb3) into dev (5ba8539) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##              dev     #843   +/-   ##
=======================================
  Coverage   40.06%   40.06%           
=======================================
  Files         558      558           
  Lines       32288    32286    -2     
  Branches     1869     1869           
=======================================
  Hits        12935    12935           
+ Misses      19169    19167    -2     
  Partials      184      184           
Flag Coverage Δ
integrationtests 31.29% <0.00%> (+<0.01%) ⬆️
unittests 27.76% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/popup/src/components/NumberInput.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ba8539...e8a7eb3. Read the comment docs.

@RickStormBringer RickStormBringer marked this pull request as draft March 29, 2022 09:11
@RickStormBringer RickStormBringer marked this pull request as ready for review March 29, 2022 09:15
@mergify mergify bot merged commit 97d74b3 into dev Mar 29, 2022
@mergify mergify bot deleted the fix-logic-bugs branch March 29, 2022 09:25
RickStormBringer added a commit that referenced this pull request Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants