Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong chainid logic #881

Merged
merged 1 commit into from
Apr 12, 2022
Merged

fix: wrong chainid logic #881

merged 1 commit into from
Apr 12, 2022

Conversation

yqrashawn
Copy link
Contributor

@yqrashawn yqrashawn commented Apr 12, 2022

PORTAL-2867


This change is Reviewable

@AngeliaQ
Copy link
Contributor

@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #881 (3a04df6) into dev (97f4f88) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##              dev     #881   +/-   ##
=======================================
  Coverage   40.17%   40.17%           
=======================================
  Files         560      560           
  Lines       32799    32799           
  Branches     1884     1884           
=======================================
  Hits        13176    13176           
  Misses      19439    19439           
  Partials      184      184           
Flag Coverage Δ
integrationtests 31.76% <0.00%> (ø)
unittests 27.38% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/rpcs/cfx_chainId/index.js 90.90% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97f4f88...3a04df6. Read the comment docs.

@mergify mergify bot merged commit 1cbc8e6 into dev Apr 12, 2022
@mergify mergify bot deleted the fix/chain-id-logic branch April 12, 2022 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants