Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: do checksum if input addr is mixed case #888

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Conversation

yqrashawn
Copy link
Contributor

@yqrashawn yqrashawn commented Apr 13, 2022

PORTAL-2879


This change is Reviewable

@AngeliaQ
Copy link
Contributor

@codecov
Copy link

codecov bot commented Apr 13, 2022

Codecov Report

Merging #888 (c13fe16) into dev (e6a5953) will decrease coverage by 0.02%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##              dev     #888      +/-   ##
==========================================
- Coverage   40.20%   40.17%   -0.03%     
==========================================
  Files         560      560              
  Lines       32813    32814       +1     
  Branches     1991     1885     -106     
==========================================
- Hits        13192    13183       -9     
- Misses      19437    19447      +10     
  Partials      184      184              
Flag Coverage Δ
integrationtests 31.77% <66.66%> (-0.05%) ⬇️
unittests 27.39% <66.66%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/account/index.js 98.05% <66.66%> (+3.94%) ⬆️
packages/rpc-engine/src/error.js 79.66% <0.00%> (-20.34%) ⬇️
packages/rpc-engine/middlewares/fetch.js 97.79% <0.00%> (-1.48%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6a5953...c13fe16. Read the comment docs.

Copy link
Contributor

@zctocm zctocm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yqrashawn)

@mergify mergify bot merged commit e9b783e into dev Apr 13, 2022
@mergify mergify bot deleted the feat/addr-checksum branch April 13, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants