fix(sign): add none standard field after estimate #968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #968 +/- ##
=======================================
Coverage 40.12% 40.12%
=======================================
Files 563 563
Lines 33274 33273 -1
Branches 1915 1915
=======================================
Hits 13352 13352
+ Misses 19739 19738 -1
Partials 183 183
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
yqrashawn
force-pushed
the
fix/eth-sign-tx-estimate
branch
from
8ba8759 to
4cb0329
Compare
yqrashawn
force-pushed
the
fix/eth-sign-tx-estimate
branch
from
e4a5347 to
4f843a5
Compare
|
Task linked: PORTAL-3040 修复 Bug: Conflux eSpace Testnet 名称优化 |
zctocm
approved these changes
Apr 27, 2022
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @yqrashawn)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PORTAL-3046
This change is