Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scale canvas to proper width/height even under high-DPI scaling #125

Merged
merged 4 commits into from
Aug 21, 2022
Merged

Scale canvas to proper width/height even under high-DPI scaling #125

merged 4 commits into from
Aug 21, 2022

Conversation

ScoreUnder
Copy link
Collaborator

@ScoreUnder ScoreUnder commented Aug 21, 2022 •
edited
Loading

Fix #122

Requires testing on

  • Linux, normal DPI
  • Linux, high DPI
  • Windows, normal DPI
  • Windows, high DPI
  • MacOS, whatever you can get lmao I don't know if you can turn it off and on

@ConnorDY
Copy link
Owner

ConnorDY commented Aug 21, 2022 •
edited
Loading

This is quite broken on my Mac...

Screen.Recording.2022-08-21.at.5.46.42.PM.mov

@ScoreUnder
Copy link
Collaborator Author

I think we might need to just put a platform check in for MacOS then, wow

@ScoreUnder
Use non-highDPI width and height on MacOS
5eea923 
For some reason it doesn't behave quite the same
ConnorDY
ConnorDY previously approved these changes Aug 21, 2022
View reviewed changes
@ScoreUnder ScoreUnder merged commit e8d60b8 into main Aug 21, 2022
@ScoreUnder ScoreUnder deleted the canvas-scaling branch August 21, 2022 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ConnorDY ConnorDY ConnorDY approved these changes

Assignees
No one assigned
Labels
bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Preview is wrongly sized in high DPI modes
2 participants
@ScoreUnder @ConnorDY