Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location dedup #142

Merged
merged 8 commits into from
Sep 11, 2022
Merged

Location dedup #142

merged 8 commits into from
Sep 11, 2022

Conversation

ScoreUnder
Copy link
Collaborator

No description provided.

Verified

This commit was signed with the committer’s verified signature.
frapell Franco Pellegrini
@ScoreUnder ScoreUnder requested a review from ConnorDY September 11, 2022 18:49
@ScoreUnder ScoreUnder marked this pull request as ready for review September 11, 2022 18:49
@ScoreUnder
Copy link
Collaborator Author

@ConnorDY can you check that the UI is still sane & the merged regions aren't too weird to look up?

@ConnorDY
Copy link
Owner

@ConnorDY can you check that the UI is still sane & the merged regions aren't too weird to look up?

Everything looks good to me. I just sent Uber a beta build and asked him to look at the locations too.

Could you update the CHANGELOG to include a Maintenance entry for this?

ConnorDY
ConnorDY previously approved these changes Sep 11, 2022
Copy link
Owner

@ConnorDY ConnorDY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update CHANGELOG.md then merge (see above comment).

@ScoreUnder ScoreUnder merged commit 07e0d9f into main Sep 11, 2022
@ScoreUnder ScoreUnder deleted the location-dedup branch September 11, 2022 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants