Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow partial data when merge #23

Merged
merged 1 commit into from
Feb 14, 2022

Conversation

benjaminkwokhuen
Copy link
Contributor

Fix #22

@k-ode
Copy link
Contributor

k-ode commented Feb 11, 2022

Thanks for the pr (and for writing a test)!

This will swallow all errors, which I don't think is what you want most of the time. It's probably easier to just remove this check from getRealTypeFromObject in utils.ts

@benjaminkwokhuen
Copy link
Contributor Author

@k-ode Fixed. It'll return null if the property does not exist.

@k-ode k-ode merged commit 04e0933 into ConrabOpto:main Feb 14, 2022
@k-ode
Copy link
Contributor

k-ode commented Feb 14, 2022

Released as 1.0.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xxx property missing from xxxModel model
2 participants