Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove direct dependency on vertx. #139

Merged
merged 2 commits into from
Jan 31, 2022
Merged

Conversation

ajsutton
Copy link
Contributor

@ajsutton ajsutton commented Jan 31, 2022

PR Description

vertx was only included as a direct dependency to override the default implementation of a tuweni-bytes method with a more optimised form. The latest tuweni has it's own DelegatingBytes class so switch to using that and remove ours along with the direct dependency on vertx.

Also delete the unused Bytes52 class.

vertx was only included as a direct dependency to override the default implementation of a tuweni-bytes method with a more optimised form. Since that method is never used (because vertx isn't used elsewhere) the default unoptimised version is fine and the direct dependency can be removed.
Copy link
Contributor

@rolfyone rolfyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajsutton ajsutton merged commit 30f9e34 into Consensys:master Jan 31, 2022
@ajsutton ajsutton deleted the remove-vertx branch January 31, 2022 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants