Remove direct dependency on vertx. #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vertx was only included as a direct dependency to override the default implementation of a tuweni-bytes method with a more optimised form. Since that method is never used (because vertx isn't used elsewhere) the default unoptimised version is fine and the direct dependency can be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
vertx was only included as a direct dependency to override the default implementation of a tuweni-bytes method with a more optimised form. The latest tuweni has it's own
DelegatingBytesclass so switch to using that and remove ours along with the direct dependency on vertx.Also delete the unused
Bytes52class.