Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate ENR field keys ordering and uniqueness #140

Merged
merged 2 commits into from
Feb 7, 2022

Conversation

Nashatyrev
Copy link
Contributor

PR Description

Special thanks to @asanso for finding and reporting this issue 👍

Discovery doesn't validate field key ordering and uniqueness of wire ENRs. Thus any number of ENRs with valid signature could be generated and feed to the discovery. Any severe security impact was not found.

As per spec:

The key/value pairs must be sorted by key and must be unique, i.e. any key may be present only once.

Copy link
Contributor

@tbenr tbenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nashatyrev Nashatyrev merged commit 55ff351 into Consensys:master Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants