Make ExternalAddressSelector pluggable
#141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In Teku we enable/disable the automatic update of the ENR via the newAddressHandler https://github.com/ConsenSys/teku/blob/6b5d530cf7cb00527aeaef5a472eab64f2011c78/ne[…]pegasys/teku/networking/p2p/discovery/discv5/DiscV5Service.java |
ajsutton
approved these changes
Feb 10, 2022
Oh, right! That could indeed do the trick. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Currently there is no mean to set a fixed external advertised address if doesn't match the address seen by other discv5 nodes: the local node record is overridden due to
Pingresponses.This PR makes
ExternalAddressSelectorpluggable so the client code could replace the default selector withNOOPor any other custom implementation