Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignore list for nodes to avoid quick recheck after failed livenes… #145

Merged
merged 5 commits into from
Mar 7, 2022

Conversation

zilm13
Copy link
Contributor

@zilm13 zilm13 commented Mar 3, 2022

…s check

PR Description

Ignore table for peers, after peer fails to response on liveness check, it's added to ignore table for 30 seconds. During this period it's not added to the buckets and no rechecks are running for it.
I don't like the way I check this in KBucket but current architecture is weird and there is a big part of my miscount in it. I definitely want to see SafeFuture there one day.

Fixed Issue(s)

Should fix #124

@zilm13 zilm13 requested a review from ajsutton March 3, 2022 16:03
@CLAassistant
Copy link

CLAassistant commented Mar 3, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basic structure looks good - mostly just the concurrency issues to sort out.

@zilm13
Copy link
Contributor Author

zilm13 commented Mar 4, 2022

@ajsutton updated according to feedback

Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zilm13 zilm13 enabled auto-merge (squash) March 7, 2022 10:59
@zilm13 zilm13 disabled auto-merge March 7, 2022 10:59
@zilm13 zilm13 merged commit 23e76cf into Consensys:master Mar 7, 2022
@zilm13 zilm13 deleted the feature/track-evicted-peers branch March 7, 2022 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check for recently evicted peers before adding them to the node table.
3 participants