Add ignore list for nodes to avoid quick recheck after failed livenes… #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ajsutton
reviewed
Mar 4, 2022
src/main/java/org/ethereum/beacon/discovery/database/ExpirationSet.java
Outdated
Show resolved
Hide resolved
src/main/java/org/ethereum/beacon/discovery/database/ExpirationSet.java
Outdated
Show resolved
Hide resolved
src/main/java/org/ethereum/beacon/discovery/database/ExpirationSet.java
Outdated
Show resolved
Hide resolved
src/main/java/org/ethereum/beacon/discovery/database/ExpirationSet.java
Outdated
Show resolved
Hide resolved
src/main/java/org/ethereum/beacon/discovery/liveness/LivenessChecker.java
Outdated
Show resolved
Hide resolved
src/main/java/org/ethereum/beacon/discovery/liveness/LivenessChecker.java
Outdated
Show resolved
Hide resolved
|
@ajsutton updated according to feedback |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s check
PR Description
Ignore table for peers, after peer fails to response on liveness check, it's added to ignore table for 30 seconds. During this period it's not added to the buckets and no rechecks are running for it.
I don't like the way I check this in
KBucketbut current architecture is weird and there is a big part of my miscount in it. I definitely want to seeSafeFuturethere one day.Fixed Issue(s)
Should fix #124