Remove usage of web3j library #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajsutton
reviewed
Jun 7, 2022
src/main/java/org/ethereum/beacon/discovery/util/Functions.java
Outdated
Show resolved
Hide resolved
src/test/java/org/ethereum/beacon/discovery/schema/NodeSessionTest.java
Outdated
Show resolved
Hide resolved
| private static final int RECIPIENT_KEY_LENGTH = 16; | ||
| private static final int INITIATOR_KEY_LENGTH = 16; | ||
| private static final int AUTH_RESP_KEY_LENGTH = 16; | ||
| private static final int MS_IN_SECOND = 1000; | ||
|
|
||
| private static final Supplier<SecureRandom> SECURE_RANDOM = Suppliers.memoize(SecureRandom::new); | ||
|
|
||
| private static boolean SKIP_SIGNATURE_VERIFY = false; | ||
| static { | ||
| Security.addProvider(PROVIDER = new BouncyCastleProvider()); |
There was a problem hiding this comment.
It would be better to init PROVIDER inline and then just have
Suggested change
| Security.addProvider(PROVIDER = new BouncyCastleProvider()); | |
| Security.addProvider(PROVIDER); |
That said, I don't see where PROVIDER is being used. Why did this move from Hashes to here?
There was a problem hiding this comment.
Why did this move from Hashes to here?
Good question, by some (static) magic it run before everything until this update and doesn't run anymore. I've refactored it a bit to be sure it runs before anything BC-dependent
src/main/java/org/ethereum/beacon/discovery/util/Functions.java
Outdated
Show resolved
Hide resolved
src/main/java/org/ethereum/beacon/discovery/util/Functions.java
Outdated
Show resolved
Hide resolved
src/main/java/org/ethereum/beacon/discovery/util/Functions.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Adrian Sutton <adrian@symphonious.net>
Co-authored-by: Adrian Sutton <adrian@symphonious.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Removes
web3j-cryptoandweb3j-rlpusage across code in favor oftuweniDesign consideration:
There is a
SecretKeyintuweni-cryptowithBytes32source of the private key which is not copied until you use some guardedBytessource, thisSecretKeyimplements finalize filling source with00's, and when you create anotherSecretKeywith the sameBytes32source and secondSecretKeymarked to be collected with GC, private key is erased in both as both uses the same instance ofBytes32(it was not actually copied). From one side it's a good thing to guarantee erasure of data but it forces to use singleSecretKeyinstance all over the library avoiding to create it when really needed.I've considered wrapping
SecretKeywith someSignerinterface to hide implementation and benefit from test'sNoopSigner, but when parameterized it goes straight fromIdentitySchemaInterpretertoNodeRecordwhich is used almost in every class in the package and should take more time to implement while I already spent more time than I should on this task.Fixed Issue(s)
Fixes #147