Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some miscellaneous things #151

Merged
merged 3 commits into from
Oct 20, 2022
Merged

Fix some miscellaneous things #151

merged 3 commits into from
Oct 20, 2022

Conversation

jtraglia
Copy link
Contributor

PR Description

Fixing some things that IntelliJ recommended:

  • Fix a bunch of little typos.
  • Remove duplicate *.swp entry from .gitignore (it's also on line 2).
  • Remove block of commented out code.
  • Make private fields in enums final.
  • Simplify Utils#optionalFlatMap method.

ajsutton
ajsutton approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@ajsutton ajsutton merged commit c4bd7c6 into Consensys:master Oct 20, 2022
@jtraglia jtraglia deleted the fix-misc-things branch October 20, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajsutton ajsutton ajsutton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtraglia @ajsutton