Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for more required fields #159

Merged
merged 7 commits into from
Oct 31, 2022

Conversation

jtraglia
Copy link
Contributor

PR Description

So for these handlers, I believe these fields should be required. As a rule of thumb, if envelope.get(FIELD) is called in the handler, FIELD should be required, right? For one instance, MessageHandler, all of the specific message handlers (NodesHandler, PingHandler, etc) seem to assume a valid session.

@ajsutton
Copy link
Contributor

Will have to dig into this one more deeply. The risk is that we wind up silently ignoring an event which makes it very hard to debug what went wrong. Currently we'd throw an exception that would get logged so would see that something is wrong.

I really dislike the whole pipeline and filtering pattern in use though so need to really think through how this fits together.

Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I just need to work out why circleci didn't run...

@ajsutton ajsutton merged commit f76b7ed into Consensys:master Oct 31, 2022
@jtraglia jtraglia deleted the require-more-fields branch October 31, 2022 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants