Check for more required fields #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will have to dig into this one more deeply. The risk is that we wind up silently ignoring an event which makes it very hard to debug what went wrong. Currently we'd throw an exception that would get logged so would see that something is wrong. I really dislike the whole pipeline and filtering pattern in use though so need to really think through how this fits together. |
ajsutton
reviewed
Oct 30, 2022
src/main/java/org/ethereum/beacon/discovery/pipeline/handler/NextTaskHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/org/ethereum/beacon/discovery/pipeline/handler/MessageHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/org/ethereum/beacon/discovery/pipeline/handler/WhoAreYouPacketHandler.java
Outdated
Show resolved
Hide resolved
src/main/java/org/ethereum/beacon/discovery/pipeline/handler/WhoAreYouPacketHandler.java
Show resolved
Hide resolved
ajsutton
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
So for these handlers, I believe these fields should be required. As a rule of thumb, if
envelope.get(FIELD)is called in the handler,FIELDshould be required, right? For one instance,MessageHandler, all of the specific message handlers (NodesHandler,PingHandler, etc) seem to assume a valid session.