Add shouldRejectInvalidTotalPackets test #160
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Well I misinterpreted the spec and thought the following sentences meant that
FindNodeResponseHandler
should ignore excess packets, instead of rejecting the response, after the allowed maximum for total.I started to "fix" it but then I noticed that it said "additional responses" and not "additional packets". So I decided to add some tests to ensure that functionality works as expected. Also, updated two things in the handler that I thought helped readability. Should we ignore additional responses after a bad response?