Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JavaCase findings #163

Merged
merged 1 commit into from
Oct 30, 2022
Merged

Fix JavaCase findings #163

merged 1 commit into from
Oct 30, 2022

Conversation

jtraglia
Copy link
Contributor

PR Description

This touches a lot of files, but the changes are pretty minor. A lot fewer findings than Teku.

  • Enable the JavaCase errorprone check.
  • Change severity from INFO to WARNING.
  • Rename logger (they're all static final) to LOG (simpler than LOGGER).
  • Rename all static final variables from camelCase to UPPER_SNAKE.
  • Rename local variables from UPPER_SNAKE to camelCase (there were just a few).
  • Rename Functions.hkdf_expand to Functions.hkdfExpand.
  • Add static qualifier to a few variables that should probably have it.
  • Suppress warnings for DiscoveryManagerTest because I think it's easier to read how it is currently.

Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you as always. :)

@ajsutton ajsutton merged commit 5381d83 into Consensys:master Oct 30, 2022
@jtraglia jtraglia deleted the fix-java-case branch October 31, 2022 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants