Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This touches a lot of files, but the changes are pretty minor. A lot fewer findings than Teku.
JavaCase
errorprone check.logger
(they're all static final) toLOG
(simpler thanLOGGER
).Functions.hkdf_expand
toFunctions.hkdfExpand
.static
qualifier to a few variables that should probably have it.DiscoveryManagerTest
because I think it's easier to read how it is currently.