Lookup lower distances if there's space #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because it used the same offset, when it reached the maximum distance it would start adding values that were not adjacent to the target distance. For example, it would produce `[255, 256, 252, 251]` which is obviously wrong.
ajsutton
reviewed
Nov 2, 2022
src/main/java/org/ethereum/beacon/discovery/task/DiscoveryTaskManager.java
Outdated
Show resolved
Hide resolved
src/main/java/org/ethereum/beacon/discovery/task/DiscoveryTaskManager.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Alternative version of #164 based on this comment. We want to prioritize higher distances, but...
This PR does exactly that.