Use Guava cache for ExpirationSet to simplify and optimise implementation #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion. Optimise stats collection in KBucket to avoid creating new lists of all nodes.
rolfyone
reviewed
Nov 4, 2022
| } | ||
| this.size = size; | ||
| public ExpirationSet(final long expirationDelayMillis, final Clock clock, final long maxSize) { | ||
| checkArgument(maxSize > 0, "Minimal size is 1"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Simplify and optimise
ExpirationSetby using guava cache. Fixes a bug where the newest item was removed when the set was full rather than the oldest.Optimise stats collection in KBucket to avoid creating new lists of all nodes.
Fixed Issue(s)
Consensys/teku#6371